This repository was archived by the owner on Mar 12, 2023. It is now read-only.
Feature/project wip #92
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usuyuki
reviewed
Mar 6, 2022
| { | ||
| return view('project.index', []); | ||
| $user = Auth::user(); | ||
| $allProjects = $this->getAllProjectsUseCase->invoke($user->id); |
Member
There was a problem hiding this comment.
[phpstan] reported by reviewdog 🐶
Cannot access property $id on App\Models\User|null.
|
|
||
| final class GetProjectUseCase | ||
| { | ||
| public function invoke( |
Member
There was a problem hiding this comment.
[phpstan] reported by reviewdog 🐶
Method App\UseCases\Project\GetProjectUseCase::invoke() has no return type specified.
usuyuki
reviewed
Mar 6, 2022
| ): Project { | ||
| $project = Project::find($projectId); | ||
|
|
||
| return $project; |
Member
There was a problem hiding this comment.
[phpstan] reported by reviewdog 🐶
Method App\UseCases\Project\GetProjectUseCase::invoke() should return App\Models\Project but returns App\Models\Project|null.
Member
|
ありがとうございます！！！ |
Member
|
Usecaseの参考としt！！ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
草庵みたいなこーど。全然かけてないです 😢